question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

New CodeAnalysis attribute breaking nanoFramework builds

See original GitHub issue

Hi,

Recently this line was added: https://github.com/AArnott/Nerdbank.GitVersioning/blob/35b087bc50864c8da8b9abfd2124f59ee31a74dd/src/Nerdbank.GitVersioning.Tasks/AssemblyVersionInfo.cs#L545

Bring the System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage attribute. Because we don’t have that attribute in nanoFramework this is breaking our builds.

If you recall we had a previous contact in #346 because of a similar problem.

Any chance that can be wrapped with compiler defs?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6

github_iconTop GitHub Comments

1reaction
AArnottcommented, Mar 6, 2020

Well we rarely change this area, so I guess we can see how far we get without in-repo validation again. Thanks for your flexibility.

0reactions
josesimoescommented, Mar 5, 2020

On a simplified approach you could just leave it as it is. Meaning that there won’t be any test for nF builds. Anything breaking the build will be picked up sooner or latter…

Read more comments on GitHub >

github_iconTop Results From Across the Web

New template of Version.new breaking nanoFramework build
Hi, We at nanoFramework are using Nerdbank.GitVersioning in our class libs. It uses it's project system and mscorlib.
Read more >
Show dotnet: Build your own unit test platform? The true ...
I'd like to show dotnet how we built a test framework for .NET nanoFramework. .NET nanoFramework is an implementation of .
Read more >
Building .NET nanoFramework in Visual Studio
Install Visual Studio 2019 Community and workloads. You should now have the pieces in place to build, deploy and debug the nanoFramework interpreter,...
Read more >
How to fail .NET 4.5 build with Microsoft.CodeAnalysis. ...
right-click on the project and go to Properties ,; go to Code Analysis tab,; in active rules there is by default Microsoft Managed ......
Read more >
QP-nano: Revision History
The QP-nano framework is being phased out and is not recommended for new product development. Version 6.8.2, 2020-06-30. Updated 3rd_party/CMSIS to version 5.7....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found