Consider using extension methods for adding extended parts to existing parts

#1387 added a bunch of methods to all the parts that are essentially doing the same thing. This should probably be reworked to be a single extension method, i.e.

public static class EmbeddedPackageExtensions
{
        /// <summary>
        /// Adds a EmbeddedPackagePart to the part
        /// </summary>
        /// <param name="contentType">The content type of the EmbeddedPackagePart</param>
        /// <param name="id">The relationship id</param>
        /// <return>The newly added part</return>
        public static EmbeddedPackagePart AddEmbeddedPackagePart(this OpenXmlPart part, string contentType, string id)
        {
            var childPart = new EmbeddedPackagePart();
            part.InitPart(childPart, contentType, id);
            return childPart;
        }

        /// <summary>
        /// Adds a EmbeddedPackagePart
        /// </summary>
        /// <param name="partType">The part type of the EmbeddedPackagePart</param>
        /// <param name="id">The relationship id</param>
        /// <return>The newly added part</return>
        public static EmbeddedPackagePart AddEmbeddedPackagePart(this OpenXmlPart part, EmbeddedPackagePartType partType, string id)
        {
            var contentType = EmbeddedPackagePartTypeInfo.GetContentType(partType);
            var partExtension = EmbeddedPackagePartTypeInfo.GetTargetExtension(partType);
            part.Features.GetRequired<IPartExtensionFeature>().Register(contentType, partExtension);
            return part.AddEmbeddedPackagePart(contentType, id);
        }

        /// <summary>
        /// Adds a EmbeddedPackagePart
        /// </summary>
        /// <param name="partType">The part type of the EmbeddedPackagePart</param>
        /// <return>The newly added part</return>
        public static EmbeddedPackagePart AddEmbeddedPackagePart(this OpenXmlPart part, EmbeddedPackagePartType partType)
        {
            var contentType = EmbeddedPackagePartTypeInfo.GetContentType(partType);
            var partExtension = EmbeddedPackagePartTypeInfo.GetTargetExtension(partType);
            part.Features.GetRequired<IPartExtensionFeature>().Register(contentType, partExtension);
            return part.AddEmbeddedPackagePart(contentType);
        }
}

[tomjebo]

@twsouthwick @mikeebowen This is the same situation with AddImagePart. I’ll also refactor AddImagePart to use a single extension method while I’m in here.

[tomjebo]

@tomjebo can this be closed?

Yup!