The OpenXmlPartContainer.DeletePart will throw exception when the id not found

Before submitting an issue, please fill this out

Is this a:

• Issue with the OpenXml library
• Question on library usage

Description

As we can see the OpenXmlPartContainer.DeletePart can delete the part, but this API will throw ArgumentOutOfRangeException when the part with the specified id does not exist.

Because the DeletePart call the DeletePartCore which will call the GetPartById to get the part.

https://github.com/OfficeDev/Open-XML-SDK/blob/0f1764a866e36d615e22d247e780fb7675046e9a/src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs#L1762

But the GetPartById will throw ArgumentOutOfRangeException when the part with the specified id does not exist.

https://github.com/OfficeDev/Open-XML-SDK/blob/0f1764a866e36d615e22d247e780fb7675046e9a/src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs#L529-L547

Yes, it means that the branch will never enter when the id not found

https://github.com/OfficeDev/Open-XML-SDK/blob/0f1764a866e36d615e22d247e780fb7675046e9a/src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs#L1764-L1768

Information

• .NET Target: All
• DocumentFormat.OpenXml Version: 2.10.1

Repro

public static void Delete(this string id, OpenXmlPart part)
{
     part.DeletePart(id);
}

Observed

The part.DeletePart will throw the exception when the part with the specified id does not exist.

Expected

As the other API design, the delete method should not throw exception the element does not exist.

[stoiveyp]

@twsouthwick I’d be interested in picking this up, seems like a straight forward change to start with

[lindexi]

@twsouthwick After https://github.com/OfficeDev/Open-XML-SDK/pull/714 merged, we can use this API to check whether the OpenXmlPartContainer contain the part with the specified id. So, there are ways to avoid this problem.

if (container.TryGetPartById(id, out _)
{
        part.DeletePart(id);
}