question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ProjectServices should dedup strings coming from MSBuild

See original GitHub issue

Looking at memory dumps of large solutions, one source of duplicate strings is the ProjectServices’s DesignTimeBuildResultCache object. @drewnoakes did a bunch of work to dedup strings when saving to and loading from the cache, but this situation is where the cache was empty and we ran a design-time build. We should consider whether we could dedup strings in this case at least within an individual cache (since there are likely going to be overlaps) and ideally across all of the strings in the cache?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
panopticoncentralcommented, Dec 19, 2019

Actually, I realized this was a mistake on my part – because the solution duplicates projects, it was creating false duplicates.

0reactions
drewnoakescommented, Dec 21, 2019

De-duping across projects may be helpful in some cases. We should get metrics on real-world solutions rather than synthesized ones.

Read more comments on GitHub >

github_iconTop Results From Across the Web

RemoveDuplicates Task - MSBuild
Learn how MSBuild uses the RemoveDuplicates task to remove duplicate items from the specified item collection.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found