question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add tool package format version metadata to packed tool in settings file

See original GitHub issue

To support better error message when future version come.

@KathleenDollard should it be SettingsVersion? it is really not about settings file. It is the format or structure(folder structure + setting file content). Maybe ToolPackageFormatVersion ?

example:

<?xml version="1.0" encoding="utf-8"?>
<DotNetCliTool>
  <Commands>
    <Command Name="mytool" EntryPoint="mytool.dll" Runner="dotnet" />
  </Commands>

  <SettingsVersion>1.0.0</SettingsVersion>
</DotNetCliTool>

And also, warning when it is not compatible (start with 1.)

cc @dotnet/dotnet-cli

  • change on CLI to warning when major version is different
  • change on SDK to put version on packtool

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:12 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
wli3commented, Mar 22, 2018

@nguerrera @KathleenDollard

Let’s move the discussion on PR here. Since it is more of a general issue https://github.com/dotnet/sdk/pull/2074#issuecomment-375136901

Nick:

I don’t have a huge opinion on this, but if the sole purpose is to mark a breaking boundary for older consumers, we could just use a single number: “1” -> “2” -> “3”.

I just wonder when we’re expected to change major, minor, patch if there are 3 parts.

Whatever scheme we use, we should be documenting when to change it.

0reactions
KathleenDollardcommented, Mar 23, 2018

Can you write the code so it ignores all but the first digit, but doesn’t crash if we need two digit numbers later.

If we don’t prepare for the possibility of two digits, then we would be forced to add another number if we are wrong and it matters what the version is, even when the change is additive and non-breaking.

Does that make sense? Otherwise I will be here a bit longer if you want to come by.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Package authoring best practices - NuGet
A general guide of best practices for creating high quality NuGet packages.
Read more >
pack command (NuGet CLI)
Creates a NuGet package based on the specified .nuspec or project file. The dotnet pack command (see dotnet Commands) and msbuild -t:pack ......
Read more >
Configuring setuptools using setup.cfg files
Setuptools allows using configuration files (usually setup.cfg ) to define a package's metadata and other options that are normally supplied to the setup() ......
Read more >
Standard way to embed version into Python package?
It provides the standard metadata version. Therefore it will be detected by pkg_resources or other tools that parse the package metadata ...
Read more >
Adding metadata to TensorFlow Lite models
Model with metadata format; Setup the metadata tools; Adding metadata using ... See Pack the associated files for more information.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found