Condense properties required for strong-name signing

In order to get strong-name signing to work, a project must have these three properties:

<PropertyGroup>
    <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Key.snk</AssemblyOriginatorKeyFile>
    <SignAssembly>true</SignAssembly>
    <PublicSign Condition="'$(OS)' != 'Windows_NT'">true</PublicSign>
</PropertyGroup>

preview2 supported strong-name signing by setting just one property: “keyFile” in project.json. It would be nice to condense this to one:

<PropertyGroup>
    <KeyFile>$(MSBuildThisFileDirectory)Key.snk</KeyFile>
</PropertyGroup>

cc @davidfowl

[natemcmaster]

To be clear, the request here was not to change existing behavior of AssemblyOriginatorKeyFile, SignAssembly, or PublicSign. The request was to add a new property (such as StrongNameKeyFile) and infer the other properties from it as necessary to make signing happen. This is a PJ parity request.

It seems this would be as simple as adding this to the SDK:

<PropertyGroup Condition="'$(StrongNameKeyFile)' != ''">
    <AssemblyOriginatorKeyFile>$(StrongNameKeyFile)</AssemblyOriginatorKeyFile>
    <SignAssembly>true</SignAssembly>
    <PublicSign Condition="'$(OS)' != 'Windows_NT'">true</PublicSign>
</PropertyGroup>

[nguerrera]

We could consider that without the public sign part (I’m not budging on that, it’s a hack – push on Roslyn, not SDK, to get rid of it), but then it would fight with the property page and open questions as to which property wins. I don’t think there’s enough value to offset that.