[dotnet migrate]"bower install " & "dotnet bundle" commands from prepublish scripts section should not be migrated from project.json to csproj
See original GitHub issueSteps to reproduce
migrate project.json to csproj with prepublish section
Expected behavior
“bower install” & “dotnet bundle” is not added to the prepublishscript section in csproj.
Actual behavior
it is getting added.
Environment data
dotnet --info
output:
Issue Analytics
- State:
- Created 7 years ago
- Comments:27 (27 by maintainers)
Top Results From Across the Web
[dotnet migrate]"bower install " & "dotnet bundle ...
[dotnet migrate]"bower install " & "dotnet bundle" commands from prepublish scripts section should not be migrated from project.json to csproj # ...
Read more >Convert a project.json to a csproj without using Visual Studio
1 Answer. There is a dotnet migrate command. The dotnet migrate command will migrate a valid Preview 2 project. json based project to...
Read more >dotnet migrate command - .NET CLI
The dotnet migrate command migrates a project and all of its dependencies.
Read more >R.I.P project.json - Out with the new, in with the old
An early look at the new csproj project format which replaces project.json in Visual Studio 2017 for .NET Core projects.
Read more >Migrating a Cross-targeted project.json .NET Core Library to ...
I opened the project in the command line and ran the migration command, which is dotnet migrate. So far so good.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I don’t think migration should drop these commands. It is fine for the new templates to not have them, but I don’t think it is ok for migration to assume that existing projects are not making use of it.
For instance, one of the issues pointed out is that bower install won’t work cross-platform. I honestly don’t see why not, as long as you have bower available on your path, it will work. Plus, if it was not working in project.json (for whatever reason), it is not the goal of migration to make your csproj now work.
Maybe I’m not following, but shouldn’t Bower always be available if the ASP.NET and web development workload is installed? See
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Web\External\bower.cmd
. If Bower isn’t available on the path, would it be more appropriate to tell the user to modify their VS 2017 installation to include the aforementioned workload?