dotnet pack puts net5.0-android in lib/net5.0 instead of lib/net5.0-android

I’m testing an Android library project similar to what we have setup here:

https://github.com/xamarin/net6-samples

I notice that the output of dotnet pack on a TargetFramework=net5.0-android library results in:

> 7z l .\bin\Release\UnnamedProject.1.0.0.nupkg
...
   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2020-10-08 10:55:52 .....          508          287  _rels\.rels
2020-10-08 10:55:52 .....          456          263  UnnamedProject.nuspec
2020-10-08 15:55:50 .....         5632         2450  lib\net5.0\UnnamedProject.dll
2020-10-08 15:55:52 .....         3345         3116  lib\net5.0-android\UnnamedProject.aar

NOTE: we have an additional .aar file here that is added via <None Include="$(OutputPath)$(TargetName).aar" Pack="true" PackagePath="lib\$(TargetFramework)" />. This works fine.

The PackTask emits a warning, that is probably related:

C:\Program Files\dotnet\sdk\5.0.100-rc.2.20480.7\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(207,5): warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add a dependency group for net5.0-android to the nuspec

The PackTask generates a .nuspec such as :

> cat .\obj\Release\UnnamedProject.1.0.0.nuspec
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>UnnamedProject</id>
    <version>1.0.0</version>
    <authors>UnnamedProject</authors>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>Package Description</description>
    <dependencies>
      <group targetFramework="net5.0" />
    </dependencies>
  </metadata>
  <files>
    <file src="C:\src\xamarin-android\bin\TestDebug\temp\DotNetPack\bin\Release\net5.0-android\UnnamedProject.dll" target="lib\net5.0\UnnamedProject.dll" />
    <file src="C:\src\xamarin-android\bin\TestDebug\temp\DotNetPack\bin\Release\net5.0-android\UnnamedProject.aar" target="lib\net5.0-android\UnnamedProject.aar" />
  </files>
</package>

This might need to be filed against the NuGet repo, not sure.

/cc @dsplaisted

[dsplaisted]

@jonathanpeppers Can you try adapting this solution (from here)?

<PropertyGroup>
  <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);IncludeReferencedProjectInPackage</TargetsForTfmSpecificContentInPackage>
</PropertyGroup>
<Target Name="IncludeReferencedProjectInPackage" Condition="'$(IncludeBuildOutput)' != 'false'">
    <GetNuGetShortFolderName
      TargetFrameworkMoniker="$(TargetFrameworkMoniker)"
      TargetPlatformMoniker="$(TargetPlatformMoniker)">
      <Output TaskParameter="NuGetShortFolderName" PropertyName="_NuGetShortFolderName" />
    </GetNuGetShortFolderName>
  <ItemGroup>
    <TfmSpecificPackageFile Include="$(OutputPath)\ReferencedLib.dll" PackagePath="lib/$(_NuGetShortFolderName)" />
  </ItemGroup>
</Target>

[jonathanpeppers]

This appears to work well: https://github.com/xamarin/xamarin-android/pull/5242

We can close this, thanks!