dotnet test should escape MSBuild special characters in filter

Inspired by @yshpakov’s dotnet/docs#13749.

dotnet test accepts a --filter option that is passed as a property on the MSBuild command line:

https://github.com/dotnet/cli/blob/cb38255c64ba0d17b06aac725c4a86ea24d79aac/src/dotnet/commands/dotnet-test/TestCommandParser.cs#L34-L39

Unfortunately, there are some test case names that use MSBuild special characters, like , (%2C). These should be escaped by the test command rather than passing the need to escape up to the user.

Repro steps and workaround:

$ dotnet new mstest
...
$  dotnet test --filter "FullyQualifiedName=MyNamespace.MyTestsClass<ParameterType1,ParameterType2>.MyTestMethod"
MSBUILD : error MSB1006: Property is not valid.
Switch: ParameterType2>.MyTestMethod

For switch syntax, type "MSBuild -help"
$ dotnet test --filter "FullyQualifiedName=MyNamespace.MyTestsClass<ParameterType1%2CParameterType2>.MyTestMethod"
Test run for S:\repro\dotnet\docs\issues\13749\bin\Debug\netcoreapp3.0\13749.dll(.NETCoreApp,Version=v3.0)
Microsoft (R) Test Execution Command Line Tool Version 16.3.0-preview-20190808-04
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
No test matches the given testcase filter `FullyQualifiedName=MyNamespace.MyTestsClass<ParameterType1,ParameterType2>.MyTestMethod` in S:\repro\dotnet\docs\issues\13749\bin\Debug\netcoreapp3.0\13749.dll

[fscottmiller]

This is phenomenal! Thank you so much. Looking forward to trying it out 😃

[yshpakov]

To me now it looks like a bug and the documentation doesn’t have a reference to MSBuild in general or to MSBuild escaping rules. At least maybe the documentation needs to be updated now:

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-test?tabs=netcore21