Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

First-chance ArgumentOutOfRangeException in NuGetUtils.cs line

See original GitHub issue

https://github.com/dotnet/sdk/blob/1e286bdb0387033b8d0a7e3a2157010ea3855360/src/Tasks/Common/NuGetUtils.cs#L53

When debugging a design-time build on the line above I see fullPath = System.Xml and dir.FullName = J:\s\src\Tools\BuildUtil. Calling substring with these arguments throws, obviously.

It is being caught in the catch block below, but still causes dozens of annoying first-chance exceptions.

Is there a check we could do to avoid the exception? Say, if the index is outside the string bounds, don’t attempt to call Substring.

Issue Analytics

State:
Created 5 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

KirillOsenkovcommented, Feb 3, 2022

Looks good I think, except I’d name the variable fullNameLength: we try to avoid using underscores in identifiers, and use camelCase for locals and parameters, and avoid abbreviations.

Would you send a Pull Request with this change?

1reaction

nguerreracommented, May 3, 2018

We should fix the TODO that even caused this approach to exist: #1091. I moved it to 2.1.4xx as well.