GenerateDepsFile no longer respects FilesToSkip from runtime packs
See original GitHub issue- Runtime pack dependencies in deps.json and in the DependencyContext model have a “runtimepack.” prefix prependend to the nuget package id (see https://github.com/dotnet/sdk/commit/16eddf3d635133c35f42974dcd491c8263066b37#diff-0723634e548f98293eebe3970b71e0ddR328).
- The heuristic in
GetPackageParts
gets the package id from the name of a nuspec in a parent directory: https://github.com/dotnet/sdk/blob/ab2176b3447e3e7820b5a340408110b6d498f907/src/Tasks/Common/NuGetUtils.cs#L48-L52
GenerateDepsFile
uses GetPackageParts
to build the list of packages with dependencies to remove. When it looks for files to trim from the dependency model, it doesn’t match any of the dependencies that have the “runtimepack.” prefix, so those files don’t get skipped.
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
"GenerateDepsFile" task failed unexpectedly. The process ...
Hello. I've been stuck on a really bad MS Build error for a few days now. Kinda at a loss as to why...
Read more >The "GenerateDepsFile" task failed unexpectedly
I update the Version of SDK , but not enough and I have the problem. I realized this: duplicate property (or variables) with...
Read more >The "GenerateDepsFile" task failed unexpectedly. I ...
The "GenerateDepsFile" task failed unexpectedly. I downloaded the VS2022 and trying to convert the .net 4.8 framework project to .Net 6 in ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@sbomer I am currently working on this. I have written test cases that fail due to this bug.
@dsplaisted any updates on this? This is important for the linker to be able to trim applications (without any unfortunate workarounds like shipping with a custom replacement for the GenerateDepsFile task).