Process.Start() fails when a directory exists in the working directory with the same name as the executable

Steps to reproduce

1. Clone corefxlab repo https://github.com/dotnet/corefxlab
2. Run ./build.sh
3. Observe failure to restore pacakges (only on OSX and Ubuntu, package restore works fine on Windows).

From: https://github.com/dotnet/corefxlab/pull/1787 https://ci.dot.net/job/dotnet_corefxlab/job/master/job/ubuntu16.04_release_prtest/807/consoleFull#7440085258bb52e59-de52-4f1c-b131-470db4c594cd

echo "Restoring all packages"
  ./$dotnetExePath restore $myFile /p:VersionSuffix="$BuildVersion"
  ret=$?
  if [ $ret -ne 0 ]; then
    echo "Failed to restore packages."
    exit -1
  fi

Expected behavior

Package restore succeeds on all configurations.

Previous CLI version (2.1.0-preview1-007191) was working as expected.

Actual behavior

Package restore failing with System.ComponentModel.Win32Exception.

18:50:13 System.ComponentModel.Win32Exception (0x80004005): The FileName property should not be a directory unless UseShellExecute is set. 18:50:13 at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo) 18:50:13 at System.Diagnostics.Process.Start() 18:50:13 at Microsoft.DotNet.Cli.Utils.ProcessStartInfoExtensions.Execute(ProcessStartInfo startInfo) 18:50:13 at Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingApp.Execute() 18:50:13 at Microsoft.DotNet.Tools.Restore.RestoreCommand.Run(String[] args) 18:50:13 at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient) 18:50:13 at Microsoft.DotNet.Cli.Program.Main(String[] args) 18:50:13

Environment data

dotnet cli version 2.1.0-preview1-007228

[livarcocc]

Because you also need to change how you are invoking dotnet:

17:18:12 dotnet-install: Installation finished successfully.
17:18:12 Restoring all packages
17:18:12 ./build.sh: line 66: ./dotnet/dotnetcli: No such file or directory
17:18:12 

This time it failed because it could not find a the file under ./dotnet/dotnetcli. And it won’t because you renamed that folder.

[ahsonkhan]

Ah yes. Good catch. Tyvm.