question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Respect property to disable targeting pack caching for runtime build

See original GitHub issue

#19570 introduced caching in ResolveTargetingPackAssets. I’m not aware of complaints from “normal” users, but for the dotnet/runtime repo, which produces those targeting packs during its build, the caching can preserve stale data.

I think this is becoming an issue in between using dotnet build on source projects where the caching feature is not disabled as the env var is only set on the build scripts and then using dotnet build or dotnet test on a test project where the platform manifest is needed.

@rainersigwald is it possible that we can also support an MSBuild property to disable the targeting pack caching?

_Originally posted by @safern in https://github.com/dotnet/runtime/issues/61451#issuecomment-982812791_

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:1
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
rainersigwaldcommented, Dec 2, 2021

We opted not to have existence/timestamp checks for cache invalidation for this particular cache because it doesn’t generally change for users during a process lifetime since everything in it is part of the .NET SDK. Timestamp checks can be surprisingly expensive.

We can add them, but I’d prefer not to if we can get away with opting into “unstable targeting pack mode” in limited circumstances like “the runtime build”.

1reaction
rainersigwaldcommented, Nov 30, 2021

Yeah, we can add an input to the task and pass a property through to it. It would require an SDK update. @marcpopMSFT would you have any objection to adding such a feature to an SDK task when the only expected consumer is the runtime build? I personally don’t . . .

_Originally posted by @rainersigwald in https://github.com/dotnet/runtime/issues/61451#issuecomment-982815610_

Read more comments on GitHub >

github_iconTop Results From Across the Web

Parallel Docker build with dotnet restore thrashes each ...
I want my builds to be as fast as possible, so I involve as much caching as possible. This is achieved in two...
Read more >
<disableCachingBindingFailures> Element
In this article​​ Specifies whether to disable the caching of binding failures that occur because the assembly was not found by probing.
Read more >
NuGet pack and restore as MSBuild targets
To suppress package dependencies from generated NuGet package, set SuppressDependenciesWhenPacking to true which will allow skipping all the ...
Read more >
Disable Managed Package Runtime
Disable Managed Package Runtime for faster FlexCard and OmniScript activation and to view and modify ... Remove an Attribute from a Target Name...
Read more >
Getting Started | Caching Data with Spring
Caching Data with Spring. This guide walks you through the process of enabling caching on a Spring managed bean. What You Will build....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found