SDK 6.0.301 -> 6.0.302 upgrade breaks our build
See original GitHub issueDescribe the bug
The VS-Platform repo build broke when the .NET SDK version installed on local dev boxes went from 6.0.301 to 6.0.302 (which released yesterday). Some kind of breaking change was made in this version of the SDK.
To Reproduce
On a machine with 6.0.301 or 6.0.302 installed
git clone https://devdiv@dev.azure.com/devdiv/DevDiv/_git/_optimized/VS-Platform
cd VS-Platform
git checkout 359c6d2f1db9b1adc15b11262aaf74ac625af938
.\init -Feature Editor
msbuild /t:rebuild src\Editor\VisualStudio\Impl\EditorImpl.csproj /r
If 6.0.302 is present, you’ll see a bunch of build errors around the CsWin32 source generator we use, such as:
C:\Users\andarno\source\repos\VS-Platform\src\Editor\VisualStudio\Impl\Microsoft.Windows.CsWin32\Microsoft.Windows.CsWin32.SourceGenerator\Windows.Win32.PInvoke.User32.g.cs(331,52): error CS0111: Type ‘PInvoke’ already defines a member called ‘SetWindowPos’ with the same parameter types [C:\Users\andarno\source\repos\VS-Platform\src\Editor\VisualStudio\Impl\EditorImpl_jqjdp0fp_wpftmp.csproj]
But with 6.0.300 or 6.0.301, the build succeeds.
Further technical details
VS 17.4 Preview 1 (32711.401.main) is installed and where the msbuild.exe used in the repro steps comes from.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:8 (5 by maintainers)
Top GitHub Comments
This is expected to be fixed this month (second Tuesday) in 6.0.304 and 6.0.401.
This did not get fixed in 6.0.303 or 6.0.400. Sorely disappointing given how broken source generators are by this regression and we waited a month for the fix and it didn’t come. What’s going on?