ThrowExceptionForHR from an SDK task fails due to missing resource

An MSBuild task in this repo that calls Marshal.ThrowExceptionForHR fails due to a missing resource assembly:

d:\sdk\artifacts\Debug\bin\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(308,5): error MSB4018: System.IO.FileNotFoundException: Could not load the specified file. [d:\sdk\artifacts\Debug\tmp\It_contains_r---AB2009D8\ResourceTest\ResourceTest.csproj]
d:\sdk\artifacts\Debug\bin\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(308,5): error MSB4018: File name: 'Microsoft.Build.Tasks.CodeAnalysis.resources' [d:\sdk\artifacts\Debug\tmp\It_contains_r---AB2009D8\ResourceTest\ResourceTest.csproj]
d:\sdk\artifacts\Debug\bin\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(308,5): error MSB4018:    at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingEvent(AssemblyName assemblyName) [d:\sdk\artifacts\Debug\tmp\It_contains_r---AB2009D8\ResourceTest\ResourceTest.csproj]
d:\sdk\artifacts\Debug\bin\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(308,5): error MSB4018:    at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingResolvingEvent(IntPtr gchManagedAssemblyLoadContext, AssemblyName assemblyName) [d:\sdk\artifacts\Debug\tmp\It_contains_r---AB2009D8\ResourceTest\ResourceTest.csproj]
d:\sdk\artifacts\Debug\bin\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(308,5): error MSB4018:    at System.Runtime.InteropServices.Marshal.ThrowExceptionForHRInternal(Int32 errorCode, IntPtr errorInfo) [d:\sdk\artifacts\Debug\tmp\It_contains_r---AB2009D8\ResourceTest\ResourceTest.csproj]

I’m not sure why this specific resource is needed by ThrowExceptionForHR. It looks like it may be caused by https://github.com/dotnet/roslyn/issues/26777.

[nguerrera]

This is fixed.

After merging master and accounting for test rename in command shown below, the appropriate exception is raised:

.dotnet\dotnet.exe test src\tests\Microsoft.NET.Build.Tests\Microsoft.NET.Build.Tests.csproj --filter "FullyQualifiedName=Microsoft.NET.Build.Tests.AppHostTests.AppHost_contains_resources_from_the_managed_dll"

D:\Src\sdk\artifacts\bin\Debug\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(328,5): error MSB4018: The "CreateAppHost" task failed unexpectedly. [D:\Src\sdk\artifacts\tmp\Debug\AppHost_conta---13435BED\ResourceTest\ResourceTest.csproj]
 D:\Src\sdk\artifacts\bin\Debug\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(328,5): error MSB4018: System.IO.DirectoryNotFoundException: The system cannot find the path specified. (0x80070003) [D:\Src\sdk\artifacts\tmp\Debug\AppHost_conta---13435BED\ResourceTest\ResourceTest.csproj]
 D:\Src\sdk\artifacts\bin\Debug\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(328,5): error MSB4018:    at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode) [D:\Src\sdk\artifacts\tmp\Debug\AppHost_conta---13435BED\ResourceTest\ResourceTest.csproj]
 D:\Src\sdk\artifacts\bin\Debug\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(328,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ResourceUpdater.ThrowExceptionForLastWin32Error() in D:\Src\sdk\src\Tasks\Microsoft.NET.Build.Tasks\ResourceUpdater.cs:line 43

[nguerrera]

That stack trace is very odd.

It is possible that latest Roslyn will fix this as the build task no longer does assembly resolve shenanigans. It might also change the symptom to something more decipherable. I will focus on that and then look at this.