question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider capturing git the line break configuration in sourcelink json

See original GitHub issue

This change in .NET SDK added assembly-level attribute with git repo clone URL: https://github.com/dotnet/sdk/pull/11559

This can be used to optimize download of all source file required to build the dll. If however, the git configuration (specifically core.eol and core.autocrlf settings) differ between the server that originally built the DLL and the local repo the re-build will produce different binaries.

It would thus be useful to record the git settings in Source Link record so that the clone can be configured the same as the build server that produced the binary.

Note: Check if git line conversion changes the BOM.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
tmatcommented, May 14, 2020

Yes, also in case when .gitattributes doesn’t specify line breaks for all files that are input to the compiler.

0reactions
bordingcommented, May 14, 2020

We only need to capture configuration that’s not stored on the source server.

I guess I’m missing when you’d think those values would matter. Are you thinking of cases where the repo doesn’t have a .gitattributes file?

Read more comments on GitHub >

github_iconTop Results From Across the Web

1.1.0 Milestone
Source Link enables a great source debugging experience for your users, ... Consider capturing git the line break configuration in sourcelink json ......
Read more >
Link /SOURCELINK option seems to do nothing
We are concerned that the linker show absolutely no output when using /SOURCELINK:"my.json" even if you give it a completely invalid json file....
Read more >
Creating JSON Configuration Files for Your Deployments
Define a deployment section to specify all your app's files and resources that you want to deploy. Tip: Consider programmatically generating the app.json...
Read more >
SOURCELINK (Include Source Link file in PDB)
Specifies a Source Link configuration file to include in the PDB file generated by the linker. Syntax. /SOURCELINK: filename. Arguments.
Read more >
How To Create a Web Server in Node.js with the HTTP ...
My first server! We've now set up a server and got our first server response. Let's break down what happened when we tested...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found