A proposal to rework bolded dates collections to HashSet in MonthCalendar

I propose to change type of _arrayOfDates, _annualArrayOfDates, _monthlyArrayOfDates collections from List to HashSet in MonthCalendar to improve performance and clean up the code. This change allows to make the implementation more logical and avoid extra checks of containing items.

User impact

• Due to HashSet can’t store duplicates of items, our collections will store only unique dates. So, if a user set some array with duplicate items to BoldedDates property, HashSet remove duplicates, and getter of BoldedDates property will return lesser collection to the user. This returned collection will be different from the initial user array. But it looks logical to me, because we shouldn’t store and show duplicate dates. But we need to discuss any cases when we must store duplicate dates.

Will this feature affect UI controls?

• No

Is your feature request related to a problem? Please describe.

• No

Describe the solution you’d like and alternatives you’ve considered

• Change type of _arrayOfDates, _annualArrayOfDates, _monthlyArrayOfDates collections from List to HashSet in MonthCalendar
• Rework related properties

[vladimir-krestov]

@Tanya-Solyanik, I would propose to close this Issue to reduce Backlog. If a customer have the issues, he/she will create a duplicate Issue. So if you agree, please close this.

[kirsan31]

1. _arrayOfDates can be populate with duplicates only through BoldedDates because AddBoldedDate not allowing them. So I already see big controversy here.
2. Duplicate dates in _arrayOfDates do not affect control in any way besides as RemoveBoldedDate will remove them one by one in each call. And the date will be bold until the last one is deleted. This is the only difference with HashSet that will remove bold on first call. And I can’t think of a practical useful use case for removing bold date in multiple passes instead of one 🤔