Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add checkable ToolStrip menu items and buttons to test applications

See original GitHub issue

.NET version

.NET 8

Did it work in .NET Framework?

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

Following up on recent accessibility improvements for checkable ToolStripMenuItem and ToolStripButton (#8307, #8961), we should add samples of such controls into our test apps.

WinFormsControlsTest app

ToolStripMenuItem. There is already a checked item on “Menus” page: but more cases should be included:
- ToolStripMenuItem with CheckState = CheckState.Unchecked and CheckOnClick = true
- ToolStripMenuItem with CheckState = CheckState.Indeterminate and CheckOnClick = true
- ToolStripMenuItem with CheckState = CheckState.Indeterminate and CheckOnClick = false
ToolStripButton. Different cases are already covered on “ToolStrips” page:

Accessibility_Core_App

ToolStripMenuItem. There are no samples of checked items on MenuToolbars_Controls - StripControls page, therefore we should add following items:
- ToolStripMenuItem with CheckState = CheckState.Unchecked and CheckOnClick = true
- ToolStripMenuItem with CheckState = CheckState.Checked and CheckOnClick = true
- ToolStripMenuItem with CheckState = CheckState.Checked and CheckOnClick = false
- ToolStripMenuItem with CheckState = CheckState.Indeterminate and CheckOnClick = true
- ToolStripMenuItem with CheckState = CheckState.Indeterminate and CheckOnClick = false
ToolStripButton. There are also no checked buttons on MenuToolbars_Controls - StripControls page, therefore we should add a set of similar cases:
- ToolStripButton with CheckState = CheckState.Unchecked and CheckOnClick = false
- ToolStripButton with CheckState = CheckState.Unchecked and CheckOnClick = true
- ToolStripButton with CheckState = CheckState.Checked and CheckOnClick = true
- ToolStripButton with CheckState = CheckState.Checked and CheckOnClick = false
- ToolStripButton with CheckState = CheckState.Indeterminate and CheckOnClick = true
- ToolStripButton with CheckState = CheckState.Indeterminate and CheckOnClick = false

Steps to reproduce

N/A

Issue Analytics

State:
Created 5 months ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

dmitrii-drobotovcommented, Apr 20, 2023

@Amy-Li03 looks good! Can you also create a pull request with these changes to the form in this repo?

2reactions

Tanya-Solyanikcommented, Apr 19, 2023

@Olina-Zhang - would your team be able to extend the accessibility test app with the suggested cases? This is a low priority work item, but hopefully a quick one.

@dmitrii-drobotov - please add these cases to WinformsControlsApp, as you would need them when porting the fix anyway.

Top Results From Across the Web

How to: Add ToolStrip Items Dynamically - Windows Forms ...

Learn how to dynamically add ToolStrip items to a ContextMenuStrip ... the menu item collection of a ToolStrip control when the menu opens....

C# Add Checkbox To WinForms Context Menu

The menu items have a Checked property ( MenuItem.Checked , ToolStripMenuItem.Checked ) that you can use for this purpose.

Access Frequently Used Features and Commands in ...

Right-click an item in the toolstrip and select Add to Quick Access Toolbar. ... Controls button and selecting or clearing the corresponding check...

Menus

Menus are a common user interface component in many types of applications. To provide a familiar and consistent user experience, ...

Python and PyQt: Creating Menus, Toolbars, and Status Bars

In this step-by-step tutorial, you'll learn how to create, customize, and use Python menus, toolbars, and status bars for creating GUI applications using ......