[API Proposal]: Allow ControlCollection.AddRange to use params keyword.

Background and motivation

Currently Control.ControlCollection.AddRange method is accepting an array of Control, this means each time that we want to add multiple controls at once, we have to make a new array. By using params keyword using this method will become easier.

API Proposal

• Add params keyword to all collection AddRange methods that don’t already have it.

namespace System.Windows.Forms;

public class Control
{
    public class ControlCollection
    {
        public virtual void AddRange(params Control[] controls);
    }
}

Likewise we want to update our other collections that have an AddRange:

// Note that parameter names are left as they currently are.

System.ComponentModel.Design.DesignerActionListCollection.AddRange(params DesignerActionList[] value)
System.Windows.Forms.AutoCompleteStringCollection.AddRange(params string[] value)
System.Windows.Forms.ComboBox.ObjectCollection.AddRange(params object[] items)
System.Windows.Forms.Design.Behavior.BehaviorServiceAdornerCollection.AddRange(params Adorner[] value)
System.Windows.Forms.Design.Behavior.GlyphCollection.AddRange(params Glyph[] value)
System.Windows.Forms.ImageList.ImageCollection.AddRange(params Image[] images)
System.Windows.Forms.ListBox.IntegerCollection.AddRange(params int[] items)
System.Windows.Forms.ListBox.ObjectCollection.AddRange(params object[] items)
System.Windows.Forms.ListView.ListViewItemCollection.AddRange(params ListViewItem[] items)
System.Windows.Forms.ListView.ColumnHeaderCollection.AddRange(params ColumnHeader[] values)
System.Windows.Forms.ListViewGroupCollection.AddRange(params ListViewGroup[] groups)
System.Windows.Forms.ListViewItem.ListViewSubItemCollection.AddRange(params ListViewSubItem[] items)
System.Windows.Forms.ListViewItem.ListViewSubItemCollection.AddRange(params string[] items)
System.Windows.Forms.TabControl.TabPageCollection.AddRange(params TabPage[] pages)
System.Windows.Forms.ToolStripItemCollection.AddRange(params ToolStripItem[] toolStripItems)
System.Windows.Forms.ToolStripPanel.ToolStripPanelRowCollection.AddRange(params ToolStripPanelRow[] value)
System.Windows.Forms.TreeNodeCollection.AddRange(params TreeNode[] nodes)

API Usage

this.Controls.AddRange(this.BtnControl1, this.BtnControl2);

Risks

No known risks.

Will this feature affect UI controls?

• No, VS Designer doesn’t need to support this feature.
• The impact will be easier use of this method by users.
• No, this feature doesn’t need to be localized.

[ALiwoto]

@elachlan

did you want to do the PR to implement it?

Yes.

@JeremyKuhne can I commit the changes to my current PR? Or I have to revert the last commit from it first?

[terrajobst]

Video

• Looks good as proposed

namespace System.Windows.Forms;

public partial class Control
{
    public partial class ControlCollection
    {
        // Existing signature:
        // public virtual void AddRange(Control[] controls);
        public virtual void AddRange(params Control[] controls);
    }
}