Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Tracking] CsWin32 API Change/Add Requests

See original GitHub issue

In the effort to start using CsWin32 (#7445), there may be APIs we’d like changed or added in cswin32 due to missing typedefs, conveniency, etc. This is a tracking issue to help keep a list of these adds/changes we would like.

CombineRgn method missing RegionType return type (https://github.com/microsoft/win32metadata/issues/1024)
RECT (https://github.com/microsoft/CsWin32/issues/626)
- Implicit converter from RECT -> Rectangle
- Width and Height properties for RECT
- Convenient constructors e.g. RECT(int left, int top, int right, int bottom)
SafeHandle usage prevents us from using convenience overloads (https://github.com/microsoft/CsWin32/issues/605)
Null value has to be explicitly cast to HINSTANCE (https://github.com/microsoft/CsWin32/issues/639)
Enum type for GetROP2/SetROP2 https://github.com/microsoft/win32metadata/issues/1045
Enum type for GetTextAlign/SetTextAlign https://github.com/microsoft/win32metadata/issues/1036
COLORREF return type for GetTextColor,GetBkColor https://github.com/microsoft/win32metadata/issues/1035
SHACF enum missing https://github.com/microsoft/win32metadata/issues/1027
Enum for IME constants https://github.com/microsoft/win32metadata/issues/1028
Mapping for XFORM > Matrix3x2
Enum type for LOGFONTW members/LF_FACESIZE https://github.com/microsoft/win32metadata/issues/1060
UXTheme APIs don’t have an HTHEME struct https://github.com/microsoft/win32metadata/issues/1273

State:
Created a year ago
Comments:16 (15 by maintainers)

Top GitHub Comments

2reactions

elachlancommented, Aug 21, 2022

Just to explain what I have been doing. I have been using ILSpy to check the win32metadata for everything in each of the interop folders. I am doing this so win32metadata is ahead of the winforms team on any differences, making the conversion easier. I am working bottom to top.

I am creating the issues first and then I will submit PRs based on feedback in the issues. This way the team has known progress to reduce project risk.

Anyone else wanting to do this is welcome. You can find steps in https://github.com/microsoft/win32metadata/blob/main/CONTRIBUTING.md

1reaction

mikebattistacommented, Aug 27, 2022

Fortunately most of your issues are just with friendly enums which are easy to add.