SDK-style WPF Projects targeting net472 are broken because ImportFrameworkWinFXTargets is false

This PR has regressed building WPF projects that use the SDK-style: https://github.com/dotnet/wpf/pull/2976

By default ImportFrameworkWinFXTargets was true, but now changes to false, resulting in MarkupCompile not running.

FYI @Nirmal4G

[Nirmal4G]

In .NET SDK’s BeforeCommon.targets These Lines 49-56 reset it to true when targeting .NETFramework but doesn’t do that! since, we set this in props in the Windows Desktop SDK. So, the solution here is, either remove the setting from the WindowsDesktop.props which may break projects or move the setting to Sdk.props and update the Main SDK logic to handle this case.

I recommend we move the setting to Sdk.props to preserve it’s intended behavior—as it was meant be used only when using the Windows Desktop SDK directly. My PR was supposed to be merged before the v5 refactoring but was delayed. Meanwhile, I didn’t know the logic was being updated in the Main SDK during that time.

I can go ahead and open a PR on what the team recommends.

[dsplaisted]

Yeah, it made sense to set this to false in WindowsDesktop.props when that was only imported if the project was explicitly using Microsoft.NET.Sdk.WindowsDesktop. But now we always import that props file.

You could move it to the WindowsDesktop Sdk.props file, I think that would work in both situations.