Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Review and update code fixers to use correct new line character sequence

See original GitHub issue

There is a bunch of code fixers which either always use CRLF when adding line breaks, or get the character sequence from document.Project.Solution.Workspace.Options.GetOption(FormattingOptions.NewLine, LanguageNames.CSharp) and thereby fail to honor a end_of_line setting in .editorconfig.

I see these:

SA1102: Currently CRLF
SA1103: Currently CRLF
SA1104: Currently CRLF
SA1107: Currently CRLF
SA1116: Currently CRLF
SA1127: Currently CRLF
SA1132: Currently CRLF
SA1133: Currently CRLF
SA1134: Currently CRLF
SA1136: Currently CRLF
SA1200, SA1208-SA1211, SA1216, SA1217 (UsingCodeFixProvider): Currently CRLF
SA1201-SA1204, SA1214 (ElementOrderCodeFixProvider): Currently CRLF
SA1212: Currently CRLF
SA1213: Currently CRLF
SA1500: Currently CRLF
SA1501: Currently CRLF
SA1502: Currently CRLF
SA1504: Currently CRLF
SA1507: Currently Workspace.Options
SA1513: Currently CRLF (See #3360)
SA1514: Currently CRLF
SA1515: Currently CRLF
SA1516: Currently CRLF
SA1600: Currently Workspace.Options
SA1609 Currently Workspace.Options
SA1615: Currently Workspace.Options
SA1642: Currently Workspace.Options
SA1633-SA1638, SA1640, SA1641 (FileHeaderCodeFixProvider): Currently Workspace.Options (See #3247)

I assume the primary updates should be to either look at surrounding text and use the existing new line sequence or read from an .editorconfig file. What is the wanted behaviour for the ones listed above?

Issue Analytics

State:
Created 4 months ago
Comments:8 (6 by maintainers)

Top GitHub Comments

1reaction

bjornhellandercommented, May 16, 2023

@MartyIX It could be specified there, or in a .globalconfig, or as an IDE setting. Simply adapting to what is already used would make it work without having to worry about different ways of configuring newlines. As long as the file is consistent, that is. But if it’s not, then would this shortcut really make it worse? 😃 Just an idea.

1reaction

manfred-brandscommented, May 16, 2023

According to a comment Roslyn formats codefixes. This came up in the nunit.analyzers and as far as I tested it that seems to be the case.