Add documentation about getButtonProps applying type: 'button' by default

• downshift version: 2.0.10
• node version: 9.11.1
• npm (or yarn) version: 1.7.0

Relevant code or config N/A

Problem description: I was trying to toggle Downshift when submitting a form by pressing Enter in an input, thinking that the form would submit (normal behaviour), but it didn’t. Looking at #315 I saw why and “fixed” it (because the current behaviour makes more sense). However, maybe we should document it?

Suggested solution: We could add a simple note such as below:

Note that getButtonProps applies type: 'button' by default, so make sure to pass type: 'submit' to this control prop if you want to have the normal behaviour of a button inside a form.

[arthurdenner]

I totally missed that openMenu prop, thanks for pointing it out, @stipsan.

By using that, I can accomplish the same behavior with a more correct code and without getButtonProps as @kentcdodds said.

Thank you both!

[stipsan]

Thanks for sharing the example, it makes it more clear what you mean 😄

Have you considered customizing the submit event that is currently calling e.preventDefault() and use the openMenu prop in there to open downshift? In my experience relying on how browsers deal with onClick on submit buttons when hitting enter on text inputs can be really flaky between browsers. It can also make the code harder to maintain since the logic flow rely on behaviors that are implicit 😅