Using event.preventDownshiftDefault = true triggers React warning

• downshift version: 1.31.2
• node version: 8.9.4
• npm (or yarn) version: npm 5.8.0

Relevant code or config

{...getItemProps({
  onClick: event => {
    event.preventDownshiftDefault = true;
  },
  item,
  label: item,
})}

What you did: I was preventing the default downshift handler from executing.

What happened: React triggered a warning

index.js:2178 Warning: This synthetic event is reused for performance reasons. If you’re seeing this, you’re adding a new property in the synthetic event object. The property is never released. See https://fb.me/react-event-pooling for more information. Reproduction repository:

Problem description: Functionality works as expected, but not sure if the warning can be prevented. Suggested solution: If warning is normal for Dev mode, add a note to docs.

[cudba]

Just stumbled upon this aswell. An other issue that appears is that on subsequent events (like keydown), the event.preventDownshiftDefault = true is still set (as the react warning suggests). So for example keydown navigation doesnt work anymore. For now, i’m setting it to false in the else clause:

getInputProps({
     onKeyDown(event) {
         if (event.key === 'Enter') {
            event.preventDownshiftDefault = true;
         } else {
            event.preventDownshiftDefault = false;
         }
     }
})

[jonavila]

@kentcdodds I thought to myself: “The feature has been out for almost a month. I’m must doing something wrong, hahaha”. BTW, Downshift is awesome. I’ve just been getting familiar with it in the past day or so. I’ll dig up ticket on why event.preventDefault is not a good option.