Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

If state doesn't exist, it should raise an error

See original GitHub issue

This is confusing:

>>> import date
>>> import holidays
>>> date(2021,3,8) in holidays.CountryHoliday("DE", state="BE")    # should raise an error, because state="BE" does not exist
False
>>> date(2021,3,8) in holidays.CountryHoliday("DE", prov="BE")
True

The first line after the imports should better raise an error, because for Germany one has to use prov and not state. At the moment this leads to subtle bugs in computing wether a day is a holiday or not.

Issue Analytics

State:
Created 2 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

mborsetticommented, Jan 18, 2022

Hi Maurizio/@dr-prodigy! I agree with subdiv, which is why I gave you three choices! 😃

#586 is fixed; I will be handling this next in my spare time.

1reaction

mborsetticommented, Jan 13, 2022

@dr-prodigy I have a proposed solution.

According to the README, we don’t have a single country where we use both state and prov. Since this is the case, I propose we simplify everything by conforming to ISO 3166-2 and call these subdivisions (argument name subdivision or subd) and make everything simple.

We can maintain backwards compatibility by assigning the value of either state or prov, if specified, to subdivision.

If you agree I can do global changes this weekend and submit a PR.