Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Behave consistent around dark theme

See original GitHub issue

Kind (Required)

  • Proposal / Discussion

Overview (Required)

  • Currently app is themed with system settings (related: #465) on launch. It seems to behave like MODE_NIGHT_FOLLOW_SYSTEM so switching system dark settings updates switch in app as well.
  • However, once check/uncheck the dark theme switch, it behaves as MODE_NIGHT_YES/MODE_NIGHT_NO. At that time, switching system dark settings no longer updates switch in app.
  • It is good to add MODE_NIGHT_FOLLOW_SYSTEM so that user can choose fixed(dark/light) or system dependent.

How about it?


Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

ytRinocommented, Jan 21, 2020

yes, I intended what you said maybe. I’m planing that of Gmail app. image Both dark/light is app overridables and default is system dependent. If we implement #465 without this, we can no longer have system dependent once user switched it in app. What user will see in preferences screen in app (after #465 )

without this with this
launch (not selected any) “dark” or “light”
(behavior is system default)
“system default”
launch with “system default” (not available) “system default”
launch with “dark” “dark” “dark”
launch with “light” “light” “light”
ytRinocommented, Jan 21, 2020

Thanks! I’ll continue working on this.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Consistent light and dark themes · Issue #1306 - GitHub
Expected Behavior A light theme should have a dark font on a light background consistently Current Behavior Currently many element of the UI ......
Read more >
Dark mode with design tokens - UX Collective
There is some confusion around dark mode and high contrast themes. Generally both is fine. As long as the foreground to background contrast...
Read more >
Dark UIs. The Good and the Bad. Dos and Don'ts. - Toptal
Dark UIs are dramatic, stylish, and elegant. Nevertheless, designers should tread carefully if they choose to walk on the “dark side.”.
Read more >
Dark user interface, dark behavior? The effect of 'dark mode ...
Concerning dishonesty, a set of experimental studies found that darkness may negatively affect moral behavior. Most notably, Zhong, Bohns, and Gino (2010) ...
Read more >
How to enable the ChromeOS dark theme - TechRepublic
To access the Dark Theme setting in ChromeOS, click on the shelf where the battery status, time and Wi-Fi indicator display. Select the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found