getAccessTokenFromCode return type

Describe the bug I suspect that getAccessTokenFromCode has incorect return type

To Reproduce Import lib, version 7.0.0, try to call getAccessTokenFromCode, inspect error

Expected Behavior Types in index.d.ts match actual implementation

Actual Behavior

getAccessTokenFromCode has return type Promise<string> https://github.com/dropbox/dropbox-sdk-js/blob/aac3fee5c0440fd7dc64b1dd064cb783bbf1381c/types/index.d.ts#L44

looking into the implementation of getAccessTokenFromCode I can see it returns parseResponse(res)

https://github.com/dropbox/dropbox-sdk-js/blob/7aa31a0e3b7743537583261522439655132eedbf/src/auth.js#L268-L270

which should return instance of DropboxResponse class https://github.com/dropbox/dropbox-sdk-js/blob/aac3fee5c0440fd7dc64b1dd064cb783bbf1381c/src/response.js#L30

Versions

• What version of the SDK are you using?

yarn why dropbox
=> Found "dropbox@7.0.0"

• What version of the language are you using?

yarn why typescript
=> Found "typescript@3.9.5"

• Are you using Javascript or Typescript? typescript

[greg-db]

Thanks for the report! We’ll get these types fixed up.

[rogebrd]

The PR that I opened mentions a commit to Stone that fixes the return type for all of the auto generated code. I am waiting until that code gets merged so I can run the generator to update all of the types before merging the PR.

That being said, if I missed any of the non-autogenerated return types (anything that isn’t defined in ‘lib’) please let me know and I’ll get that fixed as well!