JerseyClientConfiguration timeout not properly set on Client object from yaml

Hi all,

AFAICT, dropwizard isn’t actually setting the timeout values for jersey clients when they’re specified in a config file. Here’s my quick example (CatConfiguration is cut down for brevity):

public class CatConfiguration extends Configuration {
  @Valid
  @NotNull
  @JsonProperty("jerseyClient")
  private JerseyClientConfiguration jerseyClientConfiguration;

  public JerseyClientConfiguration getJerseyClientConfiguration() {
    return jerseyClientConfiguration;
  }

  public void setJerseyClientConfiguration(JerseyClientConfiguration jcc) {
    this.jerseyClientConfiguration = jcc;
  }
}

Config file contains:

jerseyClient:
  timeout: 3s

And when I build it (I’ve tried this with and without the “using” method)

final Client jerseyClient = new JerseyClientBuilder(environment)
        .using(catCfg.getJerseyClientConfiguration()).build(getName());
System.out.println("Timeout:");
System.out.println(jerseyClient.getConfiguration().getProperty(ClientProperties.READ_TIMEOUT));
System.out.println(catCfg.getJerseyClientConfiguration().getTimeout());

This prints

Timeout:
null
3 seconds

So seems like it’s read from the config just fine, but not actually set on the client object.

I fairly sure I haven’t messed this up - is the timeout simply failing to be set? Right now I’m just manually setting the timeout as a temporary workaround. Let me know if I’ve done something wrong, otherwise hopefully this is an easy fix. Thanks!

[nickbabcock]

Shot in the dark, do you also have to set the connectionTimeout?

jerseyClient:
  timeout: 3s
  connectionTimeout: 3s

[arteam]

I am closing this issue. Without a test case, we can’t do much.

Feel free to open a new issue against Dropwizard 0.8.5/0.9.1, if the problem still exists