Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

If patch failed, the process should exit with an error.

See original GitHub issue

Right now, if patching a package fails for some reason, for example, if file to be patched is not found, a warning is printed on the terminal and the process continues.

Warning: Patch file found for package **package-name** which is not present at ...

This is potentially dangerous and could break things in an application.

I propose that this is not enough and that the process should be exited and not allowed to complete execution and an error should be clearly indicated.

Issue Analytics

State:
Created 4 years ago
Reactions:4
Comments:8 (3 by maintainers)

Top GitHub Comments

4reactions

KonstaLcommented, Aug 8, 2019

+1 This just caused some problems with our production build. If defaulting a an error is too much, the error level should be configurable through a flag.

For example: patch-package --fail-on-warning

1reaction

JackCAcommented, Oct 23, 2019

I also would love an option to ignore these errors.

I’m doing docker-based yarn workspace microservice deploys where some packages that are patched may not exist.

But I’ve added the ones to be ignored to my .dockerignore, so that’s another option besides symlinking if you’re doing something docker-based.

Top Results From Across the Web

MS-Office patch deploy job fails in commit with exit codes ...

I am trying to apply MS-Office patches on some citrix servers installed with MS-Office 2007. I get the below exit codes from various...

RHEL patch failing with Exit Code 1 - HCL support

After applying RHEL patch fixlet to target computer, the action fails with Exit Code 1 and is not executed.

Critical Patch Update installation ended with Exit code : 73

I am trying to update patch 28810696 and facing some issue and getting exit code 73 . following are some logs for issue....

Troubleshooting Patch Manager - AWS Documentation

Problem: When you run AWS-RunPatchBaseline , patching fails with the following error. 12/20/2019 21:41:48 root [INFO]: another process has acquired yum lock ...

run-tests.sh should exit with a failure code if any tests failed

A fatal error in a spawned sub-process might not be properly caught and added as a failure to the test results array of...