Support multiple patches per package
See original GitHub issueI’ve been manually patching React Native for quite some time and I love the idea of this tool. It makes extracting a patch so much easier than the manual process I’m used to using.
The one thing that stands in the way of my complete adoption of patch-package
is its lack of support for multiple patches upon the same package. I like to separate my patches by concern, and it’d be nice if patch-package
allowed a third segment in the patch name that can be customized by the user.
For example, it’d be great if I could split my one mega-patch into the following three patch files:
patches/react-native+0.52.0+babel.patch
patches/react-native+0.52.0+cookies.patch
patches/react-native+0.52.0+scrollview.patch
patch-package
could apply the patches in lexically-sorted order. If the order of patch application matters, the user could include a sorting ordinal in the custom third segment, like such:
patches/react-native+0.52.0+00-scrollview.patch
patches/react-native+0.52.0+01-cookies.patch
The trickiest part of this will be excluding existing patches at the time that a new patch is extracted from a package. I’m not entirely sure how to handle that, but I’m also unconvinced that support for multiple patches needs to hinge on first-class support for extracting and isolating multiple patches. For now, if you want to use this power-user feature, you would just need to ensure that each patch is authored on a clean base package.
Issue Analytics
- State:
- Created 6 years ago
- Reactions:42
- Comments:29 (11 by maintainers)
Top GitHub Comments
Should similar or same like it is done in https://github.com/cweagans/composer-patches
I was looking for some feature similar to this, would love to see it implemented.