setOrder() bug for ordering class members

Hey David,

I discovered a bug in setOrder() when ordering class members.

I’m basically trying to move a class’s constructor below all of the class’s properties. But for some reason, any argument >4 passed to setOrder() gives me the following error:

Error: Argument Error (order): Range is 0 to 4, but 6 was provided.

However, in my example below, there are clearly there are more than 4 class members. Give it a try:

import Ast from 'ts-simple-ast';

const ast = new Ast();
const sourceFile = ast.createSourceFile( 'test.ts', `
    class Something {
        constructor() {}
		
        propA = 1;
        propB = 2;
        propC = 3;
        propD = 4;
        propE = 5;
        propF = 6;
        propG = 7;
    }
` );

const myClass = sourceFile.getClasses()[ 0 ];
const ctor = myClass.getConstructors()[ 0 ];

ctor.setOrder( 6 );  // <-- Any number greater than 4 here throws an error

console.log( sourceFile.getFullText() );

Why any number greater than 4 specifically? Dunno 😃 I encountered the same error on my Angular migrator too, which also gave an error for any index > 4, but with completely different source text. Came up with the above minimal reproduction separately.

This is with the latest btw: 6.10.0

[gregjacobs]

Thanks @dsherret, that did the trick!

Would be great if you could add that in the next version! Can’t ask everyone at work to modify their node_modules 😃 hehe

[gregjacobs]

Hahaha, you could add those instructions 😉 lol

Thanks for fixing!