question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

indentation's not perfect yet

See original GitHub issue

for eg- ObjectExpression or StructDeclaration doesn’t get linted for indentation:

struct Foo ({
    hello: 'world'
});

same for ArrayExpression that span over multiple lines:

uint[] ages = [
    19,
    20
];

same for CallExpression

foo ({
    'hello': 'world'
});

something like this shouldn’t bypass the wrath of solium:

foo (
    "hello", "world", "mofo"
);

1 arg per line, if you’re spreading your function call over multiple line. Need to code logic for this too

if (true)
    hello();

Also read https://github.com/duaraghav8/Solium/pull/122

without block statement, indentation raises error saying no indent before “hello()” which shouldn’t happen

indentation is a bitch o.O

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
elenadimitrovacommented, Nov 7, 2017

Thanks @duaraghav8 ! Confirming this tests ok with custom 2-space rule.

1reaction
davesagcommented, Nov 8, 2017

all good. working great now. thanks.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Adjust indents and spacing - Microsoft Support
Use Paragraph settings to change indentation, line spacing, and alignment.
Read more >
Microsoft Word: How to Indent Text in a Document - Proofed
Take text indentation, for example. The basics are very easy to grasp. But there are many extra options that you may miss if...
Read more >
First-line indents | Butterick's Practical Typography
Typically, a first-line indent should be no smaller than the current point size, or else it'll be hard to notice. It should be...
Read more >
When to indent text: Laying out narrative and dialogue in fiction
This post explains when and how to indent your narrative and dialogue according to publishing-industry convention.
Read more >
Smart indenting possible issue. #4351 - GitHub
Hello,. I don't know if this is an issue or not, because smart indenting is not well defined anywhere (what is clear is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found