Rules Wishlist

This is my wishlist for additional rules. Let me know if you are against any of them getting implemented in the core. I will work on some of them but anything else is up for grabs.

• Suggest send instead of dangerous call.value() (WIP @federicobond)
• Suggest avoiding block.timestamp as it can be manipulated by miners (only in functions) (WIP @federicobond)
• Ensure any function that uses msg.value has payable modifier (WIP @federicobond)
• Ensure fallback function has payable modifier (WIP @federicobond)
• Ensure send return value is checked.
• Extract magic number to constant
• Suggest using selfdestruct instead of deprecated suicide (WIP @federicobond)
• Suggest better storage packing (see Warning here)
• Find duplicate code (this one is hard, perhaps we can write a generic implementation and then integrate it into solium)

[Sjors]

• a function with returns should actually return for each code path, and should return the correct type
• a function without returns should not have any return statement

[duaraghav8]

@mushketyk you’re not overthinking. There are several rules which are on pause because of this problem of Solium only being file-aware instead of project-aware, ie, at any given time, a rule only has context of 1 file whereas it should have context of the entire project so any external elements can also be considered. This problem is well documented in #83

Let’s keep this rule on hold for now, because making solium project-aware is a major design change so it will take time. I’ll work on it in near future.