Failed to close writer connection

Hi

I’m running nsqd by docker with latest tag and use this library to write message to the nsqd, below is a part of my source code:

...skip

publish(topic, message) {
    const nsqWriter = new nsq.Writer(
      this.nsqHost,
      this.nsqPort,
    );

    return new Promise((resolve, reject) => {
      nsqWriter.connect();
      nsqWriter.once('error', err => reject(err));
      nsqWriter.once('ready', () => {
        nsqWriter.publish(topic, message, (err) => {
          if (err) reject(err);
          nsqWriter.close();
        });

        nsqWriter.once('closed', () => resolve());
      });
    });
  }

If I use the latest version of this lib (v0.9.2), nsqWriter.close(); will lead to Error: E_INVALID cannot CLS in current state (nsqd logging the same error too when I open -verbose flag), however when I downgrade version to v0.8.4 then everything is working fine.

[Misiu]

@dudleycarr please let me know when you fix this. I’ll be more than happy to test the changes.

[dudleycarr]

Looks like it’s only appropriate to use the CLS protocol command when using a Reader. See here: https://github.com/nsqio/nsq/blob/c164c776ab1af72706fff6cc05cd80a36771811d/nsqd/protocol_v2.go#L753

I’ll make a change to remove sending CLS for Writer.