Memory leak caused by message trackTimeout

Hej,

I’ve experienced serious memory leaks under high load (high number of NSQ messages in queue) and traced it down to the trackTimeout being set in message.coffee file (lines 23-32 ).

There are 2 things that I suspect could be the reason:

• id message does not timeout, timeout is not cleared when message.finish() is called
• compiled javascript code looks suspiciously recursive:

(trackTimeout = function() {
      var hard, soft;
      if (_this.hasResponded) {
        return;
      }
      soft = _this.timeUntilTimeout();
      hard = _this.timeUntilTimeout(true);
      _this.timedOut = !soft || !hard;
      if (!_this.timedOut) {
        return setTimeout(trackTimeout, Math.min(soft, hard));
      }
    })();

Could you please investigate and verify if this is actually the case?

[miharescic]

Hej, I’m attaching the nsqd 180s message timeout test with PR code below. max_in_flight was set to 10. Tests were run with node version v6.2.0

[dudleycarr]

Fixed in #118