Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] incorrect `call_success` value on Decoded Contract Table

See original GitHub issue

This query returns false

select call_success from gnosis_protocol_v2_ethereum.GPv2Settlement_call_settle
where call_tx_hash = '0x96c51fae0b8cc6c4d45f8a81a1c7dbe225a3a22ad08c32ca3170c2409c64c891'

but this transaction was mined:

https://etherscan.io/tx/0x96c51fae0b8cc6c4d45f8a81a1c7dbe225a3a22ad08c32ca3170c2409c64c891

Screen Shot 2022-10-13 at 12 10 09 PM

A suggested quick fix would be (sorry for postgres syntax).

UPDATE gnosis_protocol_v2_ethereum.GPv2Settlement_call_settle
SET call_success = true
WHERE call_tx_hash = '0x96c51fae0b8cc6c4d45f8a81a1c7dbe225a3a22ad08c32ca3170c2409c64c891'

but I would also be curious to know why this value is incorrect…

Furthermore this affects the cow_protocol_ethereum trades and batches tables (which would need to be refreshed).

Issue Analytics

State:
Created a year ago
Comments:14 (3 by maintainers)

Top GitHub Comments

8reactions

vegarsticommented, Oct 21, 2022

Thanks so much for identifying this issue @bh2smith! We’ve found the root cause and are working to fix it now. Will let you know when it is fixed.

3reactions

0xRobincommented, Oct 16, 2022

I took a look at the traces table, which from my understanding is the source (or uses the same source) as the decoded call tables.

Looking at all the traces (so not CoW specific) I found 520 more examples which I believe to be wrong (I checked a couple manually) https://dune.com/queries/1414050?d=1 These are found looking for tx_success=true, success=false, trace_address={}, which should normally never be the case?

They seem to be centered around a couple blocks with lots of mistakes on 05/08/2022 and now more recently more singular faulty traces since 14/09/2022

Top Results From Across the Web

Contracts — Solidity 0.8.17 documentation

For the contract given below, the compiler will generate a function called data that does not take any arguments and returns a uint...

External Calls - Ethereum Smart Contract Best Practices

Use caution when making external calls Calls to untrusted contracts can introduce several unexpected risks or errors. External calls may execute malicious code ......

Reverse Engineering a Contract - Ethereum.org

We need this function to give us the hexadecimal value because the values that are pushed prior to jumps ( JUMP and JUMPI...

Failing to decode transaction's data - Stack Overflow

I was importing IUniswapV2Router02 on my original contract thinking that the interface that I needed on my test was my contract's interface:

Decoding Ethereum smart contract data | by Yifei Huang

In this post, we will get our hands dirty and discuss the technical details of decoding Ethereum smart contract data into human readable ......