Lodash from devDependencies to dependencies in package.json
See original GitHub issueI noticed that following:
"lodash.clonedeep": "^4.5.0",
"lodash.isarray": "^4.0.0",
"lodash.isobject": "^3.0.2",
"lodash.isplainobject": "^4.0.6",
Libraries are placed under devDependancies in package.json. These are used in the library and not only in development of the library. Could you move these under dependencies so it would automatically download them when using this library?
It output errors like:
ERROR in ./node_modules/reactive-state/dist/store.js Module not found: Error: Can't resolve 'lodash.clonedeep' in '/Users/ron/Projects/test-project/node_modules/reactive-state/dist'
You can of course resolve the issue by installing them to your own project, but since it’s a dependancy of reactive-state it should be there. It did not complain about lodash.isarray
, so maybe this is only used in the tests and could stay in devDependancies. Typings can also stay in devDependancies.
Are you btw using this in production already? Do you have any plans on develop any more in the future or do you see it as complete package?
Thanks!
Issue Analytics
- State:
- Created 6 years ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
@stefyrosca This is now fixed starting version v0.2.2 (62d8166de0c74c2b4e9674c807ce5a043be8dd93)
Thank you!