[BUG] Schema set function is not called

Summary:

Type check is done before calling set function. Therefore, set function cannot transform value’s type.

Code sample:

Schema

const AlertSchema = new dynamoose.Schema({
	id: {
		type: String,
		hashKey: true,
		required: true
	},
	active: {
		type: Number,
		set: v => {
			console.log('set', v);
			return Number(v);
		},
		get: v => Boolean(v),
		index: {
			global: true
		},
		default: 1,
	}
}, {
	timestamps: {
		createdAt: 'createdAt',
		updatedAt: 'updatedAt'
	}
});

Model

const alert = await Alert.create({
	id: UUIDv4(),
	active: false
});

Current output and behavior (including stack trace):

TypeMismatch: Expected active to be of type number, instead found type boolean. at checkTypeFunction (./node_modules/dynamoose/lib/Document.ts:302:11) at Array.map (<anonymous>) at Function.<anonymous> (./node_modules/dynamoose/lib/Document.ts:321:111) at Generator.next (<anonymous>) at fulfilled (./node_modules/dynamoose/dist/Document.js:5:58)

The console.log is never triggered.

Expected output and behavior:

set function to be called.

Environment:

Operating System: macOS Operating System Version: 10.15 Node.js version (node -v): v13.10.1 NPM version: (npm -v): 6.13.7 Dynamoose version: 2.3.0-beta.1

Other:

• I have read through the Dynamoose documentation before posting this issue
• I have searched through the GitHub issues (including closed issues) and pull requests to ensure this issue has not already been raised before
• I have searched the internet and Stack Overflow to ensure this issue hasn’t been raised or answered before
• I have tested the code provided and am confident it doesn’t work as intended
• I have filled out all fields above
• I am running the latest version of Dynamoose

[wdbdesign]

This really limits the usefulness of the set and get functions (for my case at least). In v1 these functions would allow the user to use non-DynamoDB (complex) types in schema objects, and transform them to DynamoDB-compatible types on get/put.

In v2 it seems I can only use the exact type for fields, reducing the get and put functions to transformations of the type representation.

[mrosack]

For me, I’m trying to convert my v1 codebase to v2, and if set was called before type checks this would help me a lot in refactoring my code to get data the way v2 wants it. That said, I’m sure that after I get everything working/was starting from scratch I wouldn’t need this. I’ll probably just have my conversion layer be outside of dynamoose.