Autosubscriber and global topics

I believe I found a bug in the AutoSubscriber class. I need all consumers to have the same topic, and in order to achieve that I’m using the following code:

var subscriber = new AutoSubscriber(bus, "subscription-id")
{
    ConfigureSubscriptionConfiguration = config => config.WithTopic("my.topic")
};

That seems to do the trick: EasyNetQ effectively uses the same topic to bind all queues to their exchanges. But, it also creates another binding using the # wildcard, which renders the other one useless - as far as my knowledge on RabbitMQ and EasyNetQ goes.

I was able to track down the problem to this method:

private Action<ISubscriptionConfiguration> TopicInfo(AutoSubscriberConsumerInfo subscriptionInfo)
{
    var topics = GetTopAttributeValues(subscriptionInfo);
    if (topics.Count() != 0)
    {
        return GenerateConfigurationFromTopics(topics);
    }
    return configuration => configuration.WithTopic("#");
}

If a consumer doesn’t have any ForTopic attributes applied on it, the # wildcard will be used - which makes sense most of the time, but not when a “global” topic is already defined.

Am I correct to think this is a bug? If it is, I can try to fix it and send a PR.

[Pliner]

@micdenny Nice idea. It makes sense for me and this change sounds good for v7 version.

[Pliner]

It seems to be fixed in #1198.