Cannot publish messages when publisherConfirms=true and timeout=0

Subject of the issue

When I set publisherConfirms=true and timeout=0 (to have infinite timeout) at the same time in connectionString, I cannot publish (any kind of publish) messages. Subscribing messages with the same connectionString is okay though. I checked RabbitMQ management and see no message is published at all.

Your environment

• .Net Core 3.1
• EasyNetQ 3.7.1
• RabbitMQ 3.8.2

Steps to reproduce

Define a connectionString with ;publisherConfirms=true;timeout=0 properties and cannot publish messages.

This is the whole program to reproduce the issue

class Program
{
    static void Main(string[] args)
    {            
        var bus = RabbitHutch.CreateBus(
                        "host=localhost;username=guest;password=guest;publisherConfirms=true;timeout=0");

        // cannot publish message when publisherConfirms=true;timeout=0 both together

        bus.Subscribe<XMessage>(
            "freaking_subscriptionId",
                message => Console.WriteLine($"message received \"{message.Text}\"")
        );

        bus.Publish(new XMessage {Text = "something"});
        
        Console.WriteLine("press any key to exit");
        Console.ReadKey();
        bus.Dispose();
    }

    private class XMessage
    {
        public string Text {get;set;}
    }
}

Expected behaviour

the message is published and “message received” is logged in the console.

Actual behaviour

no message is published.

[Pliner]

Resolved by #1049.

@mortzi Many thanks for this issue 😉

[Pliner]

Hi @mortzi.

Thanks for the report.

From implementation point of view I could confirm that there are two bugs:

1. The case of zero timeout library shows a very sad bug when in some rare cases EasyNetQ could report that a message was sent, but it wasn’t. So we need to fix it.
2. We need to handle zero timeout as infinite 😃