OpenTelemetry support
See original GitHub issueHi, first of all thanks for your work.
RabbitMq doesn’t have OpenTelemetry integration yet, we might add the propagation of w3c trace context (traceparent
) + start to use ActivitySource
in the library to have an option of get some traces with EasyNetQ.
At the moment we can’t use IProduceConsumeInterceptor
(and consume interceptors) to add this, because it can’t know when the span ends.
For now I use reflection to do it, because I can’t override RabbitAdvancedBus.Consume
(it’s not virtual
) & it uses some internal types (like ConsumeConfiguration
).
I don’t like this approach, because it’s fragile, and it’s better to have OpenTelemetry support on EasyNetQ side. I’ll add a PR with a basic implementation without additional dependencies to OpenTelemetry packages.
upd: PR - #1610
Additional links / docs:
RabbitMq issues for tracking:
https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/776 https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1261
Issue Analytics
- State:
- Created 8 months ago
- Reactions:1
- Comments:7 (3 by maintainers)
Top GitHub Comments
@vchirikov Please give me a little more time to think about reworking IProduceConsumeInterceptor to implement tracing through it.
Is our only recourse to wait for v8 with #1628 ?