question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow overriding of all images used in Che deployment when using operator

See original GitHub issue

Describe the bug

Today, the references to the plugin brokers (both of them? are both still needed/used?) are in

https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L571-L574

Which means to update that to a new version, or to use a productized version, or a path-to-my-organization’s-airgapped-artifactory version, a user/customer has to hardcode new defaults and rebuild the Che server. This is awkward as it means literally forking the codebase just to point to a new container image.

Proposed solutuon

A better solution would be to have these values stored as env vars, as we do for other deployments like the devfile and plugin registries, so that they can be changed after deployment but before starting the first workspace.

And this decouples the versioning too, so that the same Che server can be used with a newer plugin broker, should a fix be needed in one but not the other.

We should also expose these env vars to the operator so that it can assign them via a custom resource.yaml file (as we do when deploying Che with chectl).

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
nickboldtcommented, Aug 13, 2019

So we can set these env vars after deploying Che server?

  • CHE_WORKSPACE_PLUGIN__BROKER_INIT_IMAGE
  • CHE_WORKSPACE_PLUGIN__BROKER_UNIFIED_IMAGE
0reactions
amisevskcommented, Oct 7, 2019

Updated title to reflect expanded scope (not just plugin brokers)

Read more comments on GitHub >

github_iconTop Results From Across the Web

chectl server:start does not expose all images for override
If a user wants to override ALL the images, they must use a custom resource yaml file. --che-operator-cr-yaml=che-operator-cr-yaml Path to a ...
Read more >
Deploying Che 7 with custom images (air gap environment)
Interested to learn about Deploying Che 7? Check our article explaining thoroughly how you can deploy Che 7 with custom images.
Read more >
CheCluster Custom Resource fields reference - Eclipse
The Che Operator must already have all permissions in these ClusterRoles to grant them. Enables the debug mode for Che server. Deployment override...
Read more >
Chapter 5. Advanced configuration options
Overrides the container image used in the Devfile registry deployment. This includes the image tag. Omit it or leave it empty to use...
Read more >
Overwriting Image Registries - KubeOne Documentation
The RegistryConfiguration API can currently only override all image registries, including non-Docker registries such as k8s.gcr.io and quay.io .
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found