Cannot add custom certificates for git hosts because user namespace doesn't have expected annotation
See original GitHub issueDescribe the bug
Tried to add che-git-self-signed-cert using steps from this PR-1222. Failed on step 3 because user namespace doesn’t have che.eclipse.org/workspace-namespace-owner-uid
annotation.
Che version
7.45
Steps to reproduce
- Create a config map called che-git-self-signed-cert in the namespace where CheCluster resource is stored with contents like this:
apiVersion: v1
metadata:
name: che-git-self-signed-cert
data:
githost: somewhere.else
ca.crt: <<contents of some certificate or any string really for this demonstration purposes >>
-
Set the
spec.server.gitSelfSignedCert
property of the CheCluster CR to true. -
Observe that in all namespaces marked with the
che.eclipse.org/workspace-namespace-owner-uid
annotation, there is a new configmap created with a name based on the name and namespace of the CheCluster resource in the form.
Expected behavior
In all namespaces marked with the che.eclipse.org/workspace-namespace-owner-uid
annotation, there is a new configmap created with a name based on the name and namespace of the CheCluster resource in the form
Runtime
OpenShift
Screenshots
No response
Installation method
OperatorHub
Environment
Linux
Logs
devworkspace-webhook-server-6dc696f87-g9l2p-webhook-server.log devworkspace-controller-manager-6c7b746c78-djkvk-devworkspace-controller.log
Issue Analytics
- State:
- Created a year ago
- Comments:12 (12 by maintainers)
Top GitHub Comments
@metlos: thank you for the fix! Your commit above should be cherry-picked into 7.16.x branch to be available in DS 3.0.0.
@SkorikSergey The ConfigMap must have
app.kubernetes.io/part-of=che.eclipse.org
label. Otherwiseche-operator
won’t recognize it. Pls see doc https://github.com/eclipse/che/issues/21327#issuecomment-1109816272