Cannot create a factory from repository (without devfile) that has uppercase characters in name
See original GitHub issueDescribe the bug
Cannot create a factory from repository(without devfile) that has uppercase characters in name.
There are restrictions:
Unable to create devworkspace: DevWorkspace.workspace.devfile.io "TestRepo" is invalid: metadata.name: Invalid value: "TestRepo": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
Che version
other (please specify in additional context)
Steps to reproduce
- Try to create a factory from repository(without devfile) that has uppercase characters in name, for example from this - https://github.com/SkorikSergey/TestRepo.
Expected behavior
Workspace created and started successfully.
Suggested behaviour change is that the factory / devworkspace engine will sanitize the input GH repo name to make it compliant with OCP naming rules.
Runtime
OpenShift
Screenshots
Installation method
OperatorHub
Environment
Linux
Eclipse Che Logs
No response
Additional context
Eclipse Che 7.47.0
Issue Analytics
- State:
- Created a year ago
- Comments:8 (8 by maintainers)
Top GitHub Comments
This is not a blocker because it’s a corner case: there is no devfile, the repo name has uppercase letters. But if it’s an easy fix and there is no risk to postpone the release let’s include that.
Fixed in https://github.com/eclipse-che/che-dashboard/pull/527