claimSize from CR is not taken into account during workspace startup

Describe the bug

claimSize from CR is not taken into account during workspace startup (the default value is used)

Che version

7.54@latest

Steps to reproduce

Set the following configuration in the CR and start a workspace

storage:
      pvcStrategy: per-workspace
      perWorkspaceStrategyPvcConfig:
        claimSize: 4Gi

ERROR: PVC is provisioned with the default size 5Gi, not 4Gi as defined in the config

Expected behavior

PVC with 4Gi is provisioned

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

In the operator logs after update I can see the following:

I1006 13:04:38.242291 1 request.go:668] Waited for 1.048214451s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/oauth.openshift.io/v1?timeout=32s
time="2022-10-06T13:04:40Z" level=info msg="Updating existing object: v1alpha1.DevWorkspaceOperatorConfig, name: devworkspace-config"
I1006 13:04:48.290808 1 request.go:668] Waited for 2.998730784s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/apps.openshift.io/v1?timeout=32s
time="2022-10-06T13:04:54Z" level=info msg="Successfully reconciled."

Additional context

No response

[amisevsk]

Testing this on our dogfooding cluster:

• ✔️ New workspaces are created with per-workspace strategy as intended.
• ✔️ New workspaces from factory URL (pasting a github repo in the create workspace box) are created with the controller.devfile.io/devworkspace-config attribute to specify a custom config. These workspaces respect the storage size configured in the CheCluster (currently 2Gi). This works for both the existing devfile and no devfile case.
• ❌ Workspaces created by clicking one of the sample tiles do not get the controller.devfile.io/devworkspace-config attribute and use the global defaults for storage size (5Gi)

This appears to be an issue in how the dashboard is handling workspaces. To verify if a workspace is configured to use the dwoc created by Che:

kubectl get dw <workspace-name> -o json | jq '.spec.template.attributes."controller.devfile.io/devworkspace-config"'

in addition, checking the devworkspace operator logs shows any non default values in the config used for a particular workspace:

$ kubectl logs -n openshift-operators deploy/devworkspace-controller-manager -c devworkspace-controller \
     | grep '^{' \
     | jq 'select(.devworkspace_id == "workspace1df3e7b4be9944bb")'
//...
{
  "level": "info",
  "ts": 1665069048.7958415,
  "logger": "controllers.DevWorkspace",
  "msg": "Reconciling Workspace",
  "Request.Namespace": "amisevsk-che",
  "Request.Name": "che-docs",
  "devworkspace_id": "workspace1df3e7b4be9944bb",
  "resolvedConfig": "workspace.defaultStorageSize.perWorkspace=2Gi,enableExperimentalFeatures=true"
}

[amisevsk]

Two DevWorkspaceOperatorConfigs is expected; one is created by Eclipse Che and the other is the default DevWorkspace Operator DWOC – someone created the main DWOC (probably me, to be honest) to enable experimental features in the cluster. One thing this does is enable logging diffs when objects need to be updated.

The devworkspace-operator-config dwoc can be removed if nobody needs the additional debug information, but it’s useful to have available if there are issues starting workspaces.