DevWorkspace empty creator annotation due blank UID for kubeadmin
See original GitHub issueIs your task related to a problem? Please describe.
Currently, we can get creator set as an empty string to two cases:
1. A controller is configured not to set up webhooks and as result, a creator annotation is not set during workspace creation but then propagated as an empty string to workspace related deployment, pods.
So, probably creator annotation should not be propagated at all in such case. fixed in https://github.com/devfile/devworkspace-operator/pull/73
- A user who created workspace is
kube:admin
which actually is not a real cluster user and don’t have a corresponding user record on the cluster (oc get users) and as a result its user ID is empty in the webhook handler info. So, is it OK to propagate kube:admin as “” user? Or instead we just need to deny workspace creation by kube:admin.
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Search OpenShift CI
#2102632 bug 3 months ago
#1921953 bug 14 months ago
#1990803 bug 14 months ago
#2003936 bug 12 months ago
Read more >https://openshift-release-s390x.apps.ci.l2s4.p1.op...
... from 1.16.2 to 1.18.3 * Red Hat Enterprise Linux CoreOS 45.82.202008101457-0 ### New images ... VPA - Handling empty vpa observed containers...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
For reference: there is an issue that kube:admin does not have uid https://github.com/openshift/origin/issues/24950
After discussion at latest dw cabal we decided to remove this issue from the scope of milestone “DevWorkspace Integration - STEP3”.