question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extensions running in the main Theia container should update memory limit for Theia

See original GitHub issue

Is your enhancement related to a problem? Please describe.

While most extensions we currently support have additional dependencies and thus have to run in a sidecar, some extensions run fine in the main Theia container. For these extensions, it would be better to not provision an additional sidecar with memory limit if possible.

This however, could run into an issue where installing plugins into the main Theia container causes memory issues. If a particularly memory-hungry plugin is added, it could cause the container to be killed, crashing the workspace.

Describe the solution you’d like

  1. Revise the plugin meta.yaml schema to support specifying a memory requirement for extensions that do not run in a sidecar

  2. When starting a workspace, add the specified memory requirement for all sidecar plugins to the memory limit given for the main Theia container. For example, if my workspace has

    • Theia, with a default memory limit of 512M
    • vscode-yaml, with a memory request of 256Mi (note, the vscode-yaml extension in this example would not have a containers field, and specify its memory requirement in another way)

    the workspace should be started with a default memory limit of 512 + 256 = 768Mi to prevent memory issues.

Describe alternatives you’ve considered

Doing nothing also works, but could result in a case where adding a plugin to the workspace causes the Theia container to crash. This would have to be resolved by manually increasing the memory allocated to the main Theia container. This could also be managed by specifying a generous default for Theia to accommodate a few local plugins.

Additional context

https://github.com/eclipse/che/issues/13555

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
l0rdcommented, Mar 26, 2020

Ok I see. We currently specify mem/cpu requirements at the container level. For a plugin with no containers we cannot specify the mem/cpu requirements.

0reactions
che-botcommented, Oct 1, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Theia extensions and extensibility · Issue #1347 - GitHub
Hello, here is an issue to discuss the topic of the Theia extensions, the current status and from my point of view, some...
Read more >
How to create and add extension to theia IDE?
I find what is the problem, I should add the extension to package.json and put the extension folder to node_modules folder, thx!! RichardZeyu ......
Read more >
Chapter 2. Che-Theia IDE basics - Red Hat Customer Portal
To fix this problem, increase the amount of memory for the Che-Theia IDE container: Navigate to the CodeReady Workspaces Dashboard. Select the workspace...
Read more >
Move your VS Code extension into Eclipse Che
memoryLimit: 512Mi. - type: dockerimage alias: python ... Run. Run inside Eclipse Che IDE. VS Code extensions ... Che / Theia Container. Main...
Read more >
Eclipse Che 7: New & Noteworthy
Containerizing the IDE: zero install and automate configuration. Extended Eclipse Theia, to provide a ... Extensions packaged with their dependencies.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found