Invalid docker ip address when running by cli

When starting eclipse che cli it’s trying to detect what user IP should be used by calling get_docker_host_ip. For docker 1.12.3 on mac this URL would be localhost.

Mentioned function: https://github.com/eclipse/che/blob/master/cli.sh#L285-L297

Urls returned:

INFO: ECLIPSE CHE: Use: http://192.168.65.2:8080
INFO: ECLIPSE CHE: API: http://192.168.65.2:8080/swagger

Valid urls

INFO: ECLIPSE CHE: Use: http://localhost:8080
INFO: ECLIPSE CHE: API: http://localhost:8080/swagger

Problem is most likely to be platform related (OSX and docker) This is really minor issue.

Reproduction Steps:

1. run che start
2. Wait for command to execute
3. Go to url provided in INFO: ECLIPSE CHE: Use: http://192.168.65.2:8080
4. Should finish with browser timeout
5. Go to http://localhost:8080 - it works

Che version: master (ebe8ed9fac8223fcafbdc1d08b1afe1fe8aeb446) OS and version: MacOs X El Capitan Docker version: Docker version 1.12.3, build 6b644ec Che install: [command line/source code]

[TylerJewell]

Is this the right logic?

1. If inside che-launcher, codenvy cli, or che cli, and:
2. if docker_for_mac(), then:
3. Change display_host=localhost for any presentation of the IP + port to the end user?

[benoitf]

It has been fixed in master