Need to make sure that `arbitrary-users-patch` images work on OpenShift v4

We have to do arbitrary-users-patch [1] of the community images been supported on OpenShift. During the discussion on https://github.com/openshift/origin/issues/23369 it appeared to be that CRI-O now has support for adding the entry of the user to the /etc/password if it does not exists in /etc/passwd. Assuming that CRI-O is the default contianer engine for OpenShift v4 we need to verify that our patched images work correctly on both OpenShift v3 and OpenShift v4 and there are no side-effects.

[1] https://github.com/eclipse/che-devfile-registry/tree/master/arbitrary-users-patch

[ibuziuk]

Have tested with the following devfiles form the registry against OCP v4 and was not able to spot any issues:

• java-maven - https://github.com/eclipse/che-devfile-registry/tree/master/devfiles/java-maven
• go - https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/go/devfile.yaml
• python - https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/python/devfile.yaml
• php-web-simple - https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/php-web-simple/devfile.yaml

Basically, all the workspaces started from those devfiles have a dedicated /etc/passwd entry and whoami return user, witt id like uid=1000820000(user) gid=0(root) groups=0(root),1000820000

@rhopp @l0rd I believe we can close this issue as done.

[l0rd]

@ibuziuk cool!