Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Plugin broker does not handle meta.yaml with version in x.x format

See original GitHub issue

Is your enhancement related to a problem? Please describe.

Devfile to test. Reproduced on che.openshift.io

metadata:
  name: test
components:
  - type: chePlugin
    reference: >-
      https://gist.githubusercontent.com/sleshchenko/4e5a1ab9c6d20c926449ecdb5eeda54a/raw/ca9a13ac80f2f6cb7e43d6fc76d3d00ce8c5ef1b/meta.yaml
apiVersion: 1.0.0

Used meta.yaml

apiVersion: v2
publisher: eamodio
name: gitlens
version: 10.2
type: VS Code extension
displayName: GitLens
title: GitLens
description: Supercharge the Git capabilities built into Visual Studio Code — Visualize code authorship at a glance via Git blame annotations and code lens, seamlessly navigate and explore Git repositories, gain valuable insights via powerful comparison commands, and so much more
icon: https://github.com/eamodio/vscode-gitlens/blob/master/images/gitlens-icon.png?raw=true
repository: https://github.com/eamodio/vscode-gitlens
category: Language
firstPublicationDate: '2020-03-12'
spec:
  extensions:
    - https://github.com/eamodio/vscode-gitlens/releases/download/v10.2.1/gitlens-10.2.1.vsix

here is the error:

Error: Failed to run the workspace: "The downloaded plugin 'eamodio/gitlens/10.2' configuration does not have the corresponding component in devfile. Devfile contains the following cheEditor/chePlugins: [redhat-developer/che-workspace-telemetry-woopra-backend/0.0.1, eclipse/che-theia/7.9.1, eclipse/che-machine-exec-plugin/7.9.1, eamodio/gitlens/null]"

Describe the solution you’d like

The workspace is started OR plugin broker clearly describes that version is expected to be in x.x.x format

Describe alternatives you’ve considered

I just have to be extra careful when creating meta.yaml and path

Additional context

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

amisevskcommented, Mar 12, 2020

Added context: the javadoc for the TextValue() method:

/**
 * Method to use for accessing String values.
 * Does <b>NOT</b> do any conversions for non-String value nodes;
 * for non-String values (ones for which {@link #isTextual} returns
 * false) null will be returned.
 * For String values, null is never returned (but empty Strings may be)
 *
 * @return Textual value this node contains, iff it is a textual
 *   JSON node (comes from JSON String value entry)
 */

0reactions

amisevskcommented, Mar 12, 2020

PR https://github.com/eclipse/che-plugin-registry/pull/427 adds a validation check for this issue, which wouldn’t address passing it in as a reference, but means the check script could be used to detect this issue.